iOS implementation of firebase social signIn (google, facebook, twitter) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objective files (.mm) are created to call respective sdks from firebase google, facebook, twitter Respective frameworks needed for iOS are also added to the qtfirebase_target.pri
|
I'm expecting @isipisi281 to review your code - let me know if that's not the plan :) |
new modifications, needs to be checked, especially for the photo url
|
no progress? |
|
it is being verified by Isy at the moment, as soon as I receive the confirmation, I push the updates.
you can test the version on the fork, it is working, missing some aspects. The updates will come soon.
… On 6 Feb 2018, at 13:02, Alessandro Rossi ***@***.***> wrote:
no progress?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYKMotznIgsLHh2FaqQwLSIDlZTv7yN8ks5tSBwxgaJpZM4RHmvo>.
|
|
@larpon Why is this PR still open? |
As stated 7 years ago: I'm waiting for @isipisi281 to review it. |
|
On a more serious note, I abandoned all Qt development many years ago and thus rely on skilled contributors to either fork the project and take over as maintainers OR help me test/review PRs so I can at least merge them with some confidence that someone has verified something. If none of this happens my only option is to archive it and let it bitrot or be forked to oblivion. Let me know if you have better ideas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective files (.mm) are created to call respective sdks from firebase
google, facebook, twitter
Respective frameworks needed for iOS are also added to the
qtfirebase_target.pri